Add tests, fallback properly if we can't init the cgroups #41189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
the
Team:Security-Linux Platform
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
kaiyan-sheng
approved these changes
Oct 9, 2024
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
leehinman
approved these changes
Oct 10, 2024
|
@leehinman I don't think so, since the original bug was never released. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* add tests, fallback properly if we can't init the cgroups * linter * fix test (cherry picked from commit 648ec22) # Conflicts: # libbeat/processors/add_docker_metadata/add_docker_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata.go # libbeat/processors/add_process_metadata/add_process_metadata_test.go # libbeat/processors/add_process_metadata/gosigar_cid_provider.go
4 tasks
4 tasks
fearful-symmetry
added a commit
that referenced
this pull request
Oct 11, 2024
* add tests, fallback properly if we can't init the cgroups * linter * fix test
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Turns out that we don't have any tests that actually check to see if the default cgroups callback actually initializes properly, so #41108 broke the processors on non-linux systems.
This re-adds support for systems that don't have cgroups support, and also adds tests that makes sure the processors can startup and run with the default cgroups provider.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.