-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fingerprint
file identity by default and migrate file state from native
or path
#41762
Merged
belimawr
merged 35 commits into
elastic:main
from
belimawr:40197-filestream-migrate-file-identity
Dec 19, 2024
Merged
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
eabe0f8
[Filebeat/Filestream] Fix `sourceStore.UpdateIdentifiers`
belimawr a2798fe
Fix tests
belimawr a4ff07a
Check if source matches the real file
belimawr 3ee0e78
Improve conditions to update registry and comments
belimawr 4bcebe7
Fix exiting tests
belimawr 12ac2f3
Working test
belimawr 57e6129
Run mage check and add all generated files
belimawr 2de77ca
Add unit tests for all common cases
belimawr 817155f
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr c1915a4
Add integration tests
belimawr 6f33fab
Clean up test config
belimawr 9bd1bf6
fix exiting tests
belimawr 937e671
Add test for corner case
belimawr fd8872a
Update tests to use require function
belimawr 2af67ec
Ensure old entries are removed from the registry
belimawr 4834d43
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr d8404b4
Update docs, changelog and fix lint warnings
belimawr b4f1f20
Update docs
belimawr 3d6022b
Remove inode marker from tests
belimawr 0cff3cc
Fix lint warnings
belimawr 4e73c1e
Remove inode_marker from tests and small improvements
belimawr a91a4d4
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr 7c8a3ae
Make fingerprint the default file identity
belimawr 0feb3bb
Update old tests to use the old file identity
belimawr 6730cb7
update reference
belimawr 1e92ff2
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr c1693f2
Fix Filestream tests
belimawr 09002a1
Fix filestream integration tests
belimawr 9758447
Fix more tests
belimawr 68c4a64
Fix more tests
belimawr 6feba3f
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr e858f0e
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr 8893029
implement review suggestions
belimawr d516a86
update generated files
belimawr 4859c9a
Merge branch 'main' of github.com:elastic/beats into 40197-filestream…
belimawr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
+
ensures the block below is on the same indentation as the title.