Call tlscommon.SetInsecureDefaults #42128
Open
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
backport
release-note:skip
michel-laterman
requested review from
belimawr and
khushijain21
and removed request for
a team
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
added
needs_team
kruskall
reviewed
Dec 19, 2024
| @@ -68,6 +69,7 @@ func Initialize() { | |||
| AddAllowedBackwardsCompatibleFlag("path.data") | |||
| _ = config.ConfigOverwriteFlag(nil, overwrites, "path.logs", "path.logs", "", "Logs path") | |||
| AddAllowedBackwardsCompatibleFlag("path.logs") | |||
| tlscommon.SetInsecureDefaults() | |||
There was a problem hiding this comment.
issue: this is gonna impact other apps that use beats as a library. Ideally this should be called by final products (e.g. metricbeat, filebeat, etc.). What do you think about moving this to GenRootCmdWithSettings ?
There was a problem hiding this comment.
Do you know if other products that use beats as a library also use tlscommon beside it?
There was a problem hiding this comment.
unfortunately yes :(
apm-server is an example of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Call tlscommon.SetInsecureDefaults from
libbeat/cfgfile/cfgfile.go's init to avoid a breaking change.Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
N/A
Related Issues