Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(filebeat): compress journal test files #42142

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Dec 21, 2024

Proposed commit message

save around ~32MB from the module zip, relevant for program using beats as a dependency.
Compress journal files with gzip and extract them to test tempdir

Using beats as a dependency currently adds around ~320MB of data as go cache. Most of it is useless (e.g. docs folder) and is adding unnecessary bloat for downstream users which slows down download, CI, etc.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

go test ./filebeat/input/journald/.

Related issues

Use cases

Screenshots

Logs

save around ~32MB from the module zip, relevant for program using beats as
a dependency.
Compress journal files with gzip and extract them to test tempdir
@kruskall kruskall requested a review from a team as a code owner December 21, 2024 22:31
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 21, 2024
@botelastic
Copy link

botelastic bot commented Dec 21, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Dec 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 21, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 21, 2024
@kruskall kruskall merged commit ef4c385 into elastic:main Dec 24, 2024
30 checks passed
@kruskall kruskall deleted the test/filebeat-compress-journal branch December 24, 2024 12:55
mergify bot pushed a commit that referenced this pull request Dec 24, 2024
* test(filebeat): compress journal test files

save around ~32MB from the module zip, relevant for program using beats as
a dependency.
Compress journal files with gzip and extract them to test tempdir

* lint: fix linter issues

(cherry picked from commit ef4c385)
kruskall added a commit that referenced this pull request Dec 24, 2024
* test(filebeat): compress journal test files

save around ~32MB from the module zip, relevant for program using beats as
a dependency.
Compress journal files with gzip and extract them to test tempdir

* lint: fix linter issues

(cherry picked from commit ef4c385)

Co-authored-by: kruskall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants