Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: x-pack/packetbeat: Enable GCP authentication for system tests #42391

Merged
merged 2 commits into from
Jan 22, 2025
Merged

CI: x-pack/packetbeat: Enable GCP authentication for system tests #42391

merged 2 commits into from
Jan 22, 2025

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Jan 22, 2025

Proposed commit message

Enable GCP authentication for packetbeat windows system tests. Relates to Marc's PR

Extracted gcp_auth.sh from pre-command hook for simplicity
Ran the pipeline directly for this branch. The npcap is being successfully downloaded. Some follow-up work is expected

CC @marc-gr @oakrizan

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@pazone pazone added enhancement Team:Ingest-EngProd backport-8.x Automated backport to the 8.x branch with mergify labels Jan 22, 2025
@pazone pazone requested a review from a team as a code owner January 22, 2025 10:37
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 22, 2025
@mergify mergify bot assigned pazone Jan 22, 2025
@pazone pazone merged commit 5bd76b0 into main Jan 22, 2025
148 checks passed
@pazone pazone deleted the ci_fix_npcap_download branch January 22, 2025 14:12
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
@pazone @mergify
CI: x-pack/packetbeat: Enable GCP authentication for system tests (#4…
2a41654 
…2391)

* CI: x-pack/packetbeat: Enable GCP authentication for system tests

* Made gcp_auth.sh executable

(cherry picked from commit 5bd76b0)

# Conflicts:
#	.buildkite/hooks/pre-command
@mergify mergify bot mentioned this pull request Jan 22, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

@alexsapran alexsapran alexsapran approved these changes

Assignees

@pazone pazone

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pazone @alexsapran @marc-gr