-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Doc+) quickstart+KB #8128
base: main
Are you sure you want to change the base?
(Doc+) quickstart+KB #8128
Conversation
Build failed on ... which I didn't edit. I imagine something else hidden is wrong with my update if y'all would kindly assist 🙏
|
Refer to my comment here: #8128 (comment) |
Co-authored-by: Michael Morello <[email protected]>
@barkbay, thanks! The last build timed-out but I don't have Buildkite permissions to "rebuild". Would you kindly retry that? 🙏 |
cloud-on-k8s-operator/build timed out, I retried it. However, docs-build-pr/build failed with: INFO:build_docs:asciidoctor: ERROR: quickstart.asciidoc:
line 23: illegal block content outside of partintro block |
Co-authored-by: Thibault Richard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, as mentioned in some of my comments my recollection is that we should avoid latinisms or the verb "to see", not sure it it are up-to-date recommendations when writing documentation though.
docs/orchestrating-elastic-stack-applications/elasticsearch/volume-claim-templates.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Morello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barkbay latinisms are removed, cheers; any other recommendations from you or @thbkrkr?
I think there are still a few of them introduced in this PR (~10 via
for example). As I said we used to avoid and remove them, I can't tell if we still want to apply this practice in our documentation though.
LGTM otherwise.
👋 howdy, team! This is first pass to streamline the ECK guide for common support misunderstandings. It:
{es}
and{kb}
doc variables (this is why PR looks big)