Docs landing page redesign #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
changed the title
scottybollinger
force-pushed
the
scottybollinger/landing-page
branch
from
ed8aa7b
to
7a5582d
Compare
scottybollinger
requested review from
colleenmcginnis,
kilfoyle,
leemthompo and
a team
as code owners
kilfoyle
previously approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Wow. @scottybollinger this new landing page looks gorgeous!
leemthompo
reviewed
Dec 1, 2023
extra/docs_landing.html
Outdated
| <a class="no-text-decoration" href="en/elastic-stack/current/installing-elastic-stack.html"> | ||
| <div class="card h-100"> | ||
| <div class="card-border card-border-top"></div> | ||
| <span class="inline-block float-left icon mr-2" style="background-image: url('https://images.contentstack.io/v3/assets/bltefdd0b53724fa2ce/bltcb0e79820c355263/636c1905cbd6b84ecb4851b2/stack-logo-color-32px.png');"> |
There was a problem hiding this comment.
Suggested change
| <span class="inline-block float-left icon mr-2" style="background-image: url('https://images.contentstack.io/v3/assets/bltefdd0b53724fa2ce/bltcb0e79820c355263/636c1905cbd6b84ecb4851b2/stack-logo-color-32px.png');"> | |
| <span class="inline-block float-left icon mr-2" style="background-image: url('https://images.contentstack.io/v3/assets/bltefdd0b53724fa2ce/blt0090c6239e64faf8/logo-stack-32-color.svg');"> |
Logo is a little hazy, this SVG might be be a good substitute.
There was a problem hiding this comment.
Nice catch! Fixed here 716d899
extra/docs_landing.html
Outdated
| <a class="no-text-decoration" href="https://docs.elastic.co/serverless"> | ||
| <div class="card h-100"> | ||
| <div class="card-border card-border-top"></div> | ||
| <span class="inline-block float-left icon mr-2" style="background-image: url('https://images.contentstack.io/v3/assets/bltefdd0b53724fa2ce/bltcb0e79820c355263/636c1905cbd6b84ecb4851b2/stack-logo-color-32px.png');"> |
There was a problem hiding this comment.
Suggested change
| <span class="inline-block float-left icon mr-2" style="background-image: url('https://images.contentstack.io/v3/assets/bltefdd0b53724fa2ce/bltcb0e79820c355263/636c1905cbd6b84ecb4851b2/stack-logo-color-32px.png');"> | |
| <span class="inline-block float-left icon mr-2" style="background-image: url('https://images.contentstack.io/v3/assets/bltefdd0b53724fa2ce/blt0090c6239e64faf8/logo-stack-32-color.svg');"> |
Same suggestion :)
There was a problem hiding this comment.
Nice catch! Fixed here 716d899
KOTungseth
previously approved these changes
Dec 1, 2023
scottybollinger
dismissed stale reviews from KOTungseth and kilfoyle
via
716d899
scottybollinger
force-pushed
the
scottybollinger/landing-page
branch
2 times, most recently
from
905d02c
to
9e04c79
Compare
scottybollinger
force-pushed
the
scottybollinger/landing-page
branch
from
9e04c79
to
a629ace
Compare
This was an attempt to get the fonts used in the landing page that are added by the injected marketing header to work on the PR previews. The font are restricted by CORS and my attempt at adding them here didn’t work either, so reverting those changes.
glitteringkatie
previously approved these changes
Dec 4, 2023
dedemorton
previously approved these changes
Dec 7, 2023
The “Browse all docs” section was moved above the marketing callout and need help section
scottybollinger
dismissed stale reviews from dedemorton and glitteringkatie
via
c79827a
KOTungseth
approved these changes
Dec 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR launches a redesigned docs landing page. It builds on the efforts of #2805 and adds additional styling and a bit of JavaScript to change the layout for the links at the bottom of the page to be in 2 columns and also to have a collapsable set of legacy links.
Note that the PR preview does not have the heading fonts, as they are only accessible on pages hosted on the elastic.co domain, but they will be on the live site. Here is a screenhot the live site rendered with the fonts in place: