Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move APM Guide docs to observability-docs repo #2873

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Dec 18, 2023

Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs rebuild

1 similar comment
@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs rebuild

@bmorelli25
Copy link
Member Author

@colleenmcginnis. Based on a new error, I've determined that the apm-server repository is a dependency of the Observability Guide in version 7.15. I did not test previous versions, but it's likely that this dependency exists in at least part or all of the versions between 7.15 and 7.9.

For this reason, I re-added the apm-server dependency for these versions in 943af47. After we get this PR building, we can probably copy the needed files to the observability-docs repository and remove this dependency again.

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs rebuild

@bmorelli25 bmorelli25 marked this pull request as ready for review December 19, 2023 15:33
@bmorelli25 bmorelli25 requested a review from a team as a code owner December 19, 2023 15:33
@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs rebuild

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 bmorelli25 merged commit 6c4d6df into elastic:master Dec 19, 2023
4 checks passed
@bmorelli25 bmorelli25 deleted the move-apm-docs-to-obs branch December 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants