Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apm-*): only build docs if there's a doc change #3066

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

kruskall
Copy link
Member

extend the check to all apm repositories and use a switch to make it easier to add more repo that share common file patterns

as usual nothing changes for repositories not mentioned in the switch (they always build and no git diff is run)

extend the check to all apm repositories and use a switch to
make it easier to add more repo that share common file patterns
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25
Copy link
Member

Fantastic! I added comments to your code (mostly for myself) but also since this script is pretty well documented and I wanted to keep it that way. Based on your prior testing, I'm pretty confident this will work, but I'm going to wait until tomorrow morning (my tomorrow morning) to merge. That way if things go wrong I can revert ASAP.

Thank you!

@kruskall
Copy link
Member Author

Thank you! 🙇

@bmorelli25 bmorelli25 merged commit 337a3cd into elastic:master Sep 12, 2024
3 checks passed
@kruskall kruskall deleted the feat/lazy-build-apm branch September 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants