Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CmdLine generation and caching #107

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix CmdLine generation and caching #107

merged 2 commits into from
Nov 7, 2023

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Nov 6, 2023 •
edited
Loading

What does this PR do?

When collecting process metrics the generation of cmdLine field and its caching were happening in the wrong place. This commit fixes it.

Why is it important?

It fixes an issue with metrics collection

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

## Author's Checklist

Related issues

@belimawr belimawr force-pushed the fix-my-fix-metrics-collection-win branch from b8a54bb to cd2e2aa Compare November 6, 2023 15:10
@belimawr
Fix CmdLine generation and caching
046d2ea 
When collecting process metrics the generation of `cmdLine` field and
its caching were happening in the wrong place. This commit fixes it.
@belimawr belimawr force-pushed the fix-my-fix-metrics-collection-win branch from cd2e2aa to 046d2ea Compare November 6, 2023 15:40
@belimawr belimawr marked this pull request as ready for review November 6, 2023 15:40
@belimawr belimawr requested a review from a team as a code owner November 6, 2023 15:40
@belimawr belimawr requested review from fearful-symmetry and faec and removed request for a team November 6, 2023 15:41
@belimawr belimawr added the Team:Elastic-Agent Label for the Agent team label Nov 6, 2023
@belimawr belimawr mentioned this pull request Nov 6, 2023
Merged
3 tasks
@belimawr belimawr merged commit f01a014 into elastic:main Nov 7, 2023
2 checks passed
@belimawr belimawr deleted the fix-my-fix-metrics-collection-win branch November 7, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belimawr @fearful-symmetry