Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to go 1.22 #188

Merged
merged 7 commits into from
Oct 30, 2024
Merged

update to go 1.22 #188

merged 7 commits into from
Oct 30, 2024

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Oct 28, 2024

beats and elastic-agent are already on go 1.22. Update to 1.2.

This also fixes CI failure

@VihasMakwana VihasMakwana requested a review from a team as a code owner October 28, 2024 23:00
@VihasMakwana VihasMakwana requested review from AndersonQ and belimawr and removed request for a team October 28, 2024 23:00
@VihasMakwana VihasMakwana self-assigned this Oct 28, 2024
@VihasMakwana VihasMakwana added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 28, 2024
.go-version Outdated Show resolved Hide resolved
Co-authored-by: Tiago Queiroz <[email protected]>
@VihasMakwana VihasMakwana changed the title update to go 1.22.0 update to go 1.22 Oct 29, 2024
@rdner
Copy link
Member

rdner commented Oct 29, 2024

@rowlandgeoff should we setup the automation here too, like we have in other repositories?

@rdner
Copy link
Member

rdner commented Oct 29, 2024

@rowlandgeoff
Copy link

@rowlandgeoff should we setup the automation here too, like we have in other repositories?

We chatted about this a bit in the Eng Prod office hours meeting today. The summary was that we definitely need more consistency in how we do version bumps across the repos. Various repos use dependabot, GH actions, or renovate.

This repo does have a GH action that should be bumping the version.

Looking at the comparable history in elastic-agent, it looks like the GH action will bump the patch versions, but it will not bump the minor version. That part seems to be done manually.

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @rdner comment still needs to be addressed before merging.

@VihasMakwana
Copy link
Contributor Author

@rdner can you take a look ?

@VihasMakwana VihasMakwana merged commit ab8f3d6 into elastic:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants