-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to go 1.22 #188
update to go 1.22 #188
Conversation
Co-authored-by: Tiago Queiroz <[email protected]>
@rowlandgeoff should we setup the automation here too, like we have in other repositories? |
@VihasMakwana please update versions in this file too https://github.com/elastic/elastic-agent-system-metrics/blob/main/.golangci.yml |
We chatted about this a bit in the Eng Prod office hours meeting today. The summary was that we definitely need more consistency in how we do version bumps across the repos. Various repos use dependabot, GH actions, or renovate. This repo does have a GH action that should be bumping the version.
Looking at the comparable history in elastic-agent, it looks like the GH action will bump the patch versions, but it will not bump the minor version. That part seems to be done manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @rdner comment still needs to be addressed before merging.
This reverts commit 51f894d.
@rdner can you take a look ? |
beats
andelastic-agent
are already on go 1.22. Update to 1.2.This also fixes CI failure