Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AIX support for system/filesystem #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djboris9
Copy link
Contributor

@djboris9 djboris9 commented Nov 5, 2022

What does this PR do?

It implements the filesystem listing on AIX in system/filesystem. This is done by calling the mntctl function and processing the returned vmount structures. There is nothing such as /proc/self/mounts available on AIX and therefore I had to go with CGo calling the same functions as mount or df does.

Why is it important?

This extends the AIX support for this package and metricbeat will benefit of it.
When this is merged, I will also create a PR to enable the according modules (system/filesystem, system/fsstat) in metricbeat for AIX.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

Related issues

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 5, 2022

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-05T23:12:18.745+0000

  • Duration: 3 min 36 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/elastic-agent-system-metrics.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/djboris9 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/djboris9 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/djboris9 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@djboris9 djboris9 marked this pull request as ready for review November 6, 2022 09:26
@djboris9 djboris9 requested a review from a team as a code owner November 6, 2022 09:26
@djboris9 djboris9 requested review from cmacknz and leehinman and removed request for a team November 6, 2022 09:26
@djboris9
Copy link
Contributor Author

djboris9 commented Nov 7, 2022

/test

@nimarezainia
Copy link
Contributor

@djboris9 thanks for this PR. Unfortunately at the moment we don't have the facility to test and ensure these beats are functioning correctly on AIX. We will keep this PR for such time when that is possible.

@djboris9 djboris9 mentioned this pull request Nov 8, 2022
4 tasks
@serak
Copy link

serak commented Jan 26, 2023

@djboris9 thanks for this PR. Unfortunately at the moment we don't have the facility to test and ensure these beats are functioning correctly on AIX. We will keep this PR for such time when that is possible.
we just need a successful cross compilation

@leehinman leehinman removed their request for review August 21, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants