Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_test.go - Support OCI Image Layout #4139

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jan 25, 2024

Port of elastic/beats#37727

on top of that it fixes docker packaging

@michalpristas michalpristas self-assigned this Jan 25, 2024
@michalpristas michalpristas added backport-skip skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team labels Jan 25, 2024
@michalpristas michalpristas marked this pull request as ready for review January 25, 2024 13:16
@michalpristas michalpristas requested a review from a team as a code owner January 25, 2024 13:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@cmacknz cmacknz added backport-v8.12.0 Automated backport with mergify and removed backport-skip labels Jan 25, 2024
@pchila
Copy link
Member

pchila commented Jan 25, 2024

Integration test failure is not related to this change: it's a permission issue that is fixed after commit 249430b3493fe2ca9ebfde9e72b91b9dd49b2d2e which is the latest snapshot build available in artifact api (from Jan 18 btw) I think we can force merge

@cmacknz
Copy link
Member

cmacknz commented Jan 25, 2024

When you backport to 8.12 you won't have Go 1.21, you'll need elastic/beats@79814b9

@pierrehilbert
Copy link
Contributor

Unrelated failure, I'm forcing the merge to unblock our builds

@pierrehilbert pierrehilbert merged commit ca5fdac into elastic:main Jan 25, 2024
10 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Jan 25, 2024
* fixed package_test for newer docker format

* Fixed docker packaging

* remove unwanted error package from copy.go

(cherry picked from commit ca5fdac)

# Conflicts:
#	dev-tools/packaging/package_test.go
michalpristas added a commit that referenced this pull request Jan 25, 2024
)

* package_test.go - Support OCI Image Layout (#4139)

* fixed package_test for newer docker format

* Fixed docker packaging

* remove unwanted error package from copy.go

(cherry picked from commit ca5fdac)

# Conflicts:
#	dev-tools/packaging/package_test.go

* slice contains fixed

---------

Co-authored-by: Michal Pristas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.12.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants