Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we respect OTEL instrumentation/signal configuration #131

Merged
merged 10 commits into from
Jul 18, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jul 17, 2024

This ensures we respect the OTEL_DOTNET_AUTO_INSTRUMENTATION_ENABLED, OTEL_DOTNET_AUTO_{SIGNAL}_INSTRUMENTATION_ENABLED and OTEL_DOTNET_AUTO_{SIGNAL}_{INSTRUMENTATION}_INSTRUMENTATION_ENABLED family of environment variables.

It follows the cascading rules as defined here: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/config.md#instrumentations

Renamed ELASTIC_OTEL_ENABLE_ELASTIC_DEFAULTS => ELASTIC_OTEL_DEFAULTS_ENABLED to fall more in line with other OTEL environment variable names

On top of that we now support opting in to signals & instrumentations through IConfiguration.

This now also lays the groundwork to enable/disable individual instrumentations.

I also took this opportunity to refactor the way we set ConfigSource a bit.

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 3d093c9 into main Jul 18, 2024
6 of 7 checks passed
@Mpdreamz Mpdreamz deleted the feature/otel-signal-configuration branch July 18, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants