Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split workflows according to permissions #30

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Split workflows according to permissions #30

merged 4 commits into from
Feb 6, 2024

Conversation

Mpdreamz
Copy link
Member

This splits our single workflow file over multiple.

Ensuring PR's only need read permission and our prerelease flow on main
is separated from the actual release tagging trigger more clearly.

We now also enfore 2 spaces for yml files instead of 4.

This splits our single workflow file over multiple.

Ensuring PR's only need read permission and our prerelease flow on main
is separated from the actual release tagging trigger more clearly.

We now also enfore 2 spaces for yml files instead of 4.
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just a few comments

.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/license.yml Outdated Show resolved Hide resolved
@Mpdreamz Mpdreamz requested a review from v1v February 5, 2024 15:19
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 9e8aa82 into main Feb 6, 2024
3 checks passed
@Mpdreamz Mpdreamz deleted the fix/workflows branch March 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants