Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and doc image #79

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

stevejgordon
Copy link
Contributor

No description provided.

README.md Show resolved Hide resolved
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevejgordon
Copy link
Contributor Author

If we link the images through their full path on github.com they should also display correctly on nuget see:

https://learn.microsoft.com/en-us/nuget/nuget-org/package-readme-on-nuget-org#allowed-domains-for-images-and-badges

https://www.nuget.org/packages/Elastic.OpenTelemetry/1.0.0-alpha.1

I can update although, looking at that list is it only github.com/.../workflows/.../badge.svg that they allow?

@Mpdreamz
Copy link
Member

The images can be referenced through:

raw.github.com
raw.githubusercontent.com

Which is allow listed 🎉

@stevejgordon stevejgordon merged commit d9e1437 into main Mar 28, 2024
5 checks passed
@stevejgordon stevejgordon deleted the docs/package-version-placeholder branch March 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants