Async resource providers #31
Conversation
| Map<String, String> extraConfig = new HashMap<>(); | ||
| extraConfig.put( | ||
| "otel.java.disabled.resource.providers", | ||
| ElasticResourceProvider.class.getCanonicalName()); |
There was a problem hiding this comment.
[for reviewer] This might be a good alternative to the rather complex re-packaging of the contrib resource providers to prevent them from being executed during SDK startup, but we can do that in a follow-up improvement.
There was a problem hiding this comment.
Does this overwrite or append the option?
| import io.opentelemetry.sdk.metrics.data.MetricDataType; | ||
| import io.opentelemetry.sdk.resources.Resource; | ||
|
|
||
| public class DelegatingMetricData implements MetricData { |
There was a problem hiding this comment.
[for reviewer] there is no equivalent for metrics to io.opentelemetry.sdk.trace.data.DelegatingSpanData that we already use for exporting spans, thus just fills the void and could be a relevant contribution to the upstream project.
| import java.util.concurrent.TimeUnit; | ||
| import java.util.logging.Logger; | ||
|
|
||
| public class ExecutorUtils { |
There was a problem hiding this comment.
[for reviewer] mostly copied from our current agent codebase.
| this.config = config; | ||
| if(!withExtra){ | ||
| return getBaseResource(config); | ||
| } | ||
| return getBaseResource(config).merge(getExtraResource()); |
There was a problem hiding this comment.
[for reviewer] this allows to use this provider with the SDK and make it fetch the extra attributes, or use it asynchronously with our agent distribution to limit application startup overhead.
| @@ -62,6 +62,12 @@ public static boolean isDebugging() { | |||
| return false; | |||
| } | |||
|
|
|||
| public static boolean isDebugInCI() { | |||
There was a problem hiding this comment.
[for reviewer] this is especially relevant to help debugging tests failing in CI (there is an extra checkbock when trying to re-run them).
Impact on agent init evaluated with AWS resource provider test:
AwsResourceProvidersTestTest execution duration covers multiple providers and is dominated by container startup time, thus it means about 2-3 seconds added to the application startup if resource execution is synchronous.