Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Prepare docs #328

Merged
merged 27 commits into from
Aug 15, 2024
Merged

[docs] Prepare docs #328

merged 27 commits into from
Aug 15, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Jul 12, 2024

Closes https://github.com/elastic/obs-docs-team/issues/238

Builds out minimal viable docs.

What's included

This includes the overall structure of the initial doc set. There is some missing information. I've left code comments with questions to be answered throughout the files.

Read more about what needs to be included in these docs in Elastic Distributions for of OpenTelemetry (Mini docs style guide) (internal doc).

To do

  • @colleenmcginnis add initial outline with questions for the dev team in code comments
  • @bmorelli25 high-level review of the approach (anything I should add before kicking this over to the dev team?)
  • @colleenmcginnis continue clean up / aligning across languages
  • @elastic/apm-agent-java review content that's already there, add content that's missing (especially where there are questions in code comments)
    • Feel free to either commit directly to this PR or add suggestions in PR comments — whichever works best for you!
  • @colleenmcginnis clean up content
  • 🆕 @colleenmcginnis convert to Markdown
  • 🆕 @colleenmcginnis reorganize content as needed to be consumed on GitHub
  • 🆕 @colleenmcginnis slight content reframing
  • @elastic/obs-docs peer review
  • @colleenmcginnis address feedback
  • 🆕 @colleenmcginnis update product naming as needed
  • @elastic/apm-agent-java final review, approve
  • @colleenmcginnis merge

@colleenmcginnis colleenmcginnis self-assigned this Jul 12, 2024
@colleenmcginnis colleenmcginnis changed the title [wip] Prepare docs [wip] [docs] Prepare docs Jul 12, 2024
@colleenmcginnis colleenmcginnis changed the title [wip] [docs] Prepare docs [docs] [wip] Prepare docs Jul 12, 2024
@colleenmcginnis colleenmcginnis requested a review from a team July 16, 2024 14:52
@colleenmcginnis
Copy link
Contributor Author

👋 @elastic/apm-agent-java can you please take an initial look here? I left many questions for you in code comments throughout the doc files. As you read through, if you have answers to questions, feel free to either commit directly to this PR or add suggestions in PR comments — whatever works best for you!

////
[discrete]
[[configure-auth-methods]]
=== Authentication methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs to be the same as the content for OTEL_EXPORTER_OTLP_HEADERS in https://www.elastic.co/guide/en/observability/current/apm-open-telemetry-direct.html#apm-instrument-apps-otel

It will be the same for all agents. Maybe it can be a generic doc fragment that gets included in each agent doc?

Comment on lines 156 to 159
////
Step-by-step instructions
////

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be generic to all agents. Basically open the APM UI and look at the services listed to find your service. We probably have this in a dozen places in the docs, so maybe we should have this centralized somewhere?

docs/intro.asciidoc Outdated Show resolved Hide resolved
docs/configure.asciidoc Outdated Show resolved Hide resolved
docs/get-started.asciidoc Outdated Show resolved Hide resolved
docs/configure.asciidoc Outdated Show resolved Hide resolved
docs/intro.asciidoc Outdated Show resolved Hide resolved
docs/get-started.asciidoc Outdated Show resolved Hide resolved
docs/get-started.asciidoc Outdated Show resolved Hide resolved
=== Next steps

* <<configuration,Configure the distro>> to send data to Elastic.
* Learn more about viewing and interpreting data in the {observability-guide}/apm.html[Observability guide].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can link to a more actionable page (or pages). This link kinda drops the user at a useless landing page with generic info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I was thinking of linking to a page related to the APM UI, but we'll need to merge elastic/observability-docs#3723 first.

docs/configuration.asciidoc Outdated Show resolved Hide resolved
docs/configuration.asciidoc Outdated Show resolved Hide resolved
@colleenmcginnis
Copy link
Contributor Author

Sorry @bmorelli25. This PR wasn't ready for a writer review. 😞 I'll push local changes, and then see which of your comments are still applicable.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
@SylvainJuge SylvainJuge mentioned this pull request Aug 14, 2024
10 tasks
README.md Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: jackshirazi <[email protected]>
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Outdated Show resolved Hide resolved
docs/configure.md Show resolved Hide resolved
docs/configure.md Show resolved Hide resolved
docs/get-started.md Outdated Show resolved Hide resolved
@colleenmcginnis
Copy link
Contributor Author

Thanks for your patience and collaboration here! I'll leave it up to your team when you want to merge this. It's good from my side!

@jackshirazi jackshirazi merged commit add6be8 into elastic:main Aug 15, 2024
9 checks passed
@colleenmcginnis colleenmcginnis deleted the prep-docs branch August 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants