-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse contrib resource providers + add existing ones #4
Merged
SylvainJuge
merged 25 commits into
elastic:main
from
SylvainJuge:add-aws-resource-contrib
Oct 27, 2023
Merged
reuse contrib resource providers + add existing ones #4
SylvainJuge
merged 25 commits into
elastic:main
from
SylvainJuge:add-aws-resource-contrib
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently blocked by two things:
|
…aws-resource-contrib
SylvainJuge
changed the title
add aws+gcp resource providers
reuse contrib resource providers + add existing ones
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "resource providers" that allow to capture resource attributes (that we usually refer as cloud metadata).
AWS: https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/aws-resources/
bonus: application servers resource provider
https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/resource-providers
Update the GCP one has been moved to a separate task/PR to allow merging this as it's getting quite large #27