Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UrlFormatter #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve UrlFormatter #135

wants to merge 1 commit into from
+20 −38

Conversation

flobernd
Copy link
Member

I noticed that UrlFormatter.CreateString() does not prefer custom IUrlParameter.GetString() implementations when a type as well implements IList/IEnumerable.

Besides that, the PR contains the following additional improvements:

  • Recursively call CreateString() for collection items
  • Remove duplicate enum member handling
  • Makes sure that CreateString() never returns null (there is no value in distinguishing between null and string.Empty here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Awaiting requested review from Mpdreamz

@stevejgordon stevejgordon Awaiting requested review from stevejgordon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flobernd