Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecating local param from alias req #3094

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Nov 5, 2024

Following #3059, which removes the local parameter from alias requests in version 9, we should mark it as deprecated in 8

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 38/38 38/38
indices.get_alias 🔴 82/82 73/82

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 7c12ea0 into 8.x Nov 5, 2024
8 checks passed
@l-trotta l-trotta deleted the deprecate-alias-local branch November 5, 2024 14:22
Copy link
Contributor

github-actions bot commented Nov 5, 2024

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-3094-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c12ea069c93716a6ac243d6979c977a1669d914
# Push it to GitHub
git push --set-upstream origin backport-3094-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-3094-to-8.15.

github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
l-trotta added a commit that referenced this pull request Nov 5, 2024
(cherry picked from commit 7c12ea0)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants