logs-apm.error-*: define log.level field as keyword #112440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets `log.level: "error"` as a `constant_keyword` for all apm error logs. Part of elastic/apm-server#13956 Signed-off-by: Marc Lopez Rubio <[email protected]>
elasticsearchmachine
added
v8.16.0
needs:triage
marclop
added
>bug
:Data Management/Data streams
elasticsearchmachine
removed
the
needs:triage
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @marclop, I've created a changelog YAML for you. |
axw
reviewed
Sep 3, 2024
| @@ -26,6 +26,9 @@ template: | |||
| processor.event: | |||
| type: constant_keyword | |||
| value: error | |||
| log.level: | |||
| type: constant_keyword | |||
There was a problem hiding this comment.
I'm not sure about using constant_keyword for this. I think OTel exception logs could explicitly set a log level to something other than "error", which could conflict with this.
There was a problem hiding this comment.
oh... I wasn't aware of that case. Should it then be mapped in apm-data and just added as a keyword?
There was a problem hiding this comment.
I'm not convinced we should set a default value for log.level, so wouldn't make a change to apm-data; but it makes sense to map the field as keyword.
Signed-off-by: Marc Lopez Rubio <[email protected]>
marclop
changed the title
carsonip
approved these changes
Sep 3, 2024
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
Defines `log.level` as a `keyword` for all apm error logs. --------- Signed-off-by: Marc Lopez Rubio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit defines a new mapping
log.levelas akeywordfor all apm error logs.Part of elastic/apm-server#13956