Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust analyze limit exception to be a bad_request #116325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benwtrent
Copy link
Member

The exception is due to large input on the user and is resolvable by either the user adjusting their request or changing their cluster settings. So a user focused error is preferred. I chose bad_request as it seemed like the best fit.

closes: #116323

@benwtrent benwtrent added >non-issue :Search Relevance/Analysis How text is split into tokens auto-backport Automatically create backport pull requests when merged v9.0.0 v8.17.0 labels Nov 6, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Nov 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@benwtrent benwtrent added >bug and removed >non-issue labels Nov 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @benwtrent, I've created a changelog YAML for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceeding index.analyze.max_token_count should return in a client error instead of a internal server error?
2 participants