Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in muted CSV test for scoring in ES|QL #118665

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix typo in muted CSV test for scoring in ES|QL #118665

merged 1 commit into from
Dec 13, 2024

Conversation

tteofili
Copy link
Contributor

@tteofili tteofili added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests v9.0.0 auto-backport Automatically create backport pull requests when merged v8.18.0 labels Dec 13, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@tteofili tteofili mentioned this pull request Dec 13, 2024
Merged
@ioanatia
Copy link
Contributor

I approved the PR, but do we actually have concrete failures for multi cluster specs?

@tteofili
Copy link
Contributor Author

tteofili commented Dec 13, 2024 •
edited
Loading

I approved the PR, but do we actually have concrete failures for multi cluster specs?

main vs 8.18 prior merging of #118435, and I just hate it esthetically :)

@tteofili tteofili merged commit a583a38 into elastic:main Dec 13, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118665

tteofili added a commit to tteofili/elasticsearch that referenced this pull request Dec 16, 2024
@tteofili
fix typo in muted CSV test for scoring in ES|QL (elastic#118665)
91e9135 
(cherry picked from commit a583a38)
@tteofili tteofili mentioned this pull request Dec 16, 2024
Merged
@tteofili
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

tteofili added a commit that referenced this pull request Dec 16, 2024
@tteofili
[8.x] fix typo in muted CSV test for scoring in ES|QL (#118665) (#118738
93ffc84 
)

* fix typo in muted CSV test for scoring in ES|QL (#118665)

(cherry picked from commit a583a38)
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
@tteofili @maxhniebergall
[8.x] fix typo in muted CSV test for scoring in ES|QL (elastic#118665) (
20793ed 
elastic#118738)

* fix typo in muted CSV test for scoring in ES|QL (elastic#118665)

(cherry picked from commit a583a38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@ioanatia ioanatia ioanatia approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tteofili @elasticsearchmachine @ioanatia @ChrisHegarty