-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Make Wolfi hardened Docker option more prominent #118755
Conversation
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
[TIP] | ||
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd break this out of a tip - feels like part of the primary narrative to me
since this adds security, is using wolfi images the better path? should we recommend it for everyone using an appropriate version of docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the tip point, but also I pulled main
and discovered this file had already been updated. I tried to make guidance more prominent at the outset in any case;
I assume at some point in the future the container will stop needing to be explicitly called out as wolfi once it becomes default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving. you could also consider creating tabbed options for all of the commands that reference the package name but it's not critical
💯 if this assumption is incorrect: I assume at some point in the future the container will stop needing to be explicitly called out as wolfi once it becomes default. |
Per PR title