Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Make Wolfi hardened Docker option more prominent #118755

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

leemthompo
Copy link
Contributor

Per PR title

@leemthompo leemthompo added >docs General docs changes auto-backport Automatically create backport pull requests when merged v8.16.0 v8.17.0 v8.18.0 labels Dec 16, 2024
@leemthompo leemthompo self-assigned this Dec 16, 2024
Copy link
Contributor

Documentation preview:

@leemthompo leemthompo added the Team:Docs Meta label for docs team label Dec 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Comment on lines 58 to 59
[TIP]
====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd break this out of a tip - feels like part of the primary narrative to me

since this adds security, is using wolfi images the better path? should we recommend it for everyone using an appropriate version of docker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the tip point, but also I pulled main and discovered this file had already been updated. I tried to make guidance more prominent at the outset in any case;

I assume at some point in the future the container will stop needing to be explicitly called out as wolfi once it becomes default.

@leemthompo leemthompo changed the title [DOCS] Mention Wolfi hardened option in Docker docs [DOCS] Make Wolfi hardened Docker option more prominent Dec 17, 2024
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. you could also consider creating tabbed options for all of the commands that reference the package name but it's not critical

@leemthompo
Copy link
Contributor Author

approving. you could also consider creating tabbed options for all of the commands that reference the package name but it's not critical

💯 if this assumption is incorrect:

I assume at some point in the future the container will stop needing to be explicitly called out as wolfi once it becomes default.

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.16
8.17
8.x

leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Dec 18, 2024
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Dec 18, 2024
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v8.16.0 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants