Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update match-phrase-query.asciidoc #118828

Open
wants to merge 2 commits into
base: 8.17
Choose a base branch
from
Open

Update match-phrase-query.asciidoc #118828

wants to merge 2 commits into from
+0 −3

Conversation

damien-renier-elastic
Copy link

@damien-renier-elastic damien-renier-elastic commented Dec 17, 2024 •
edited by leemthompo
Loading

Added Parameters for consistency

@damien-renier-elastic
Update match-phrase-query.asciidoc
a37669f 
Added Parameters for consistency
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

@damien-renier-elastic please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.17.1 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 17, 2024
@damien-renier-elastic damien-renier-elastic added the >docs General docs changes label Dec 17, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo
Copy link
Contributor

leemthompo commented Dec 17, 2024 •
edited
Loading

@damien-renier-elastic the changes show you deleted a paragraph about the slop flag, which doesn't seem to reflect your PR description?

@damien-renier-elastic
Copy link
Author

damien-renier-elastic commented Dec 17, 2024 •
edited
Loading

Removed 2 paragraphes:

  • slop
  • zero_terms_query

Because they are now part of the parameters section

Created the parameters paragraph instead for consistency with other methods.
Added:

  • query
  • analyzer
  • slop
  • zero_terms-query

Added a new header for the Analyzer example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.17.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damien-renier-elastic @elasticsearchmachine @leemthompo