[Inference API] Make message content optional in unified API #118998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhniebergall
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
server/src/main/java/org/elasticsearch/inference/UnifiedCompletionRequest.java
Show resolved
Hide resolved
...h/xpack/inference/external/request/openai/OpenAiUnifiedChatCompletionRequestEntityTests.java
Show resolved
Hide resolved
jonathan-buttner
approved these changes
Dec 23, 2024
| @@ -143,7 +148,7 @@ private static Content parseContent(XContentParser parser) throws IOException { | |||
|
|
|||
| public Message(StreamInput in) throws IOException { | |||
| this( | |||
| in.readNamedWriteable(Content.class), | |||
| in.readOptionalNamedWriteable(Content.class), | |||
There was a problem hiding this comment.
Just noting here we don't need to change the transport version because this code is feature flagged
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
maxhniebergall
added a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 23, 2024
…#118998) * Allow for null/empty content field * remove tests which checked for null content * [CI] Auto commit changes from spotless * Improvements from review --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 79a8226) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/request/openai/OpenAiUnifiedChatCompletionRequestEntity.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 23, 2024
#119226) * Allow for null/empty content field * remove tests which checked for null content * [CI] Auto commit changes from spotless * Improvements from review --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 79a8226) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/external/request/openai/OpenAiUnifiedChatCompletionRequestEntity.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.