Italy Regions #132
Merged
Italy Regions #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
@markov00 can you look over the geojson file in this PR? |
nickpeihl
requested changes
Oct 23, 2019
nickpeihl
reviewed
Oct 23, 2019
markov00
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
I've took a look at the geojson, seems to report correctly all the regions. I've added a small comment. LGTM after incorporating @nickpeihl requested changes
Co-Authored-By: Nick Peihl <[email protected]>
Co-Authored-By: Nick Peihl <[email protected]>
Co-Authored-By: Nick Peihl <[email protected]>
💚 Build Succeeded |
💚 Build Succeeded |
jsanz
added a commit
that referenced
this pull request
Oct 30, 2019
* Ukraine regions * Italy Regions (#132) * Italy Regions * Update sources/it/regions.hjson Co-Authored-By: Nick Peihl <[email protected]> * Update sources/it/regions.hjson Co-Authored-By: Nick Peihl <[email protected]> * Update sources/it/regions.hjson Co-Authored-By: Nick Peihl <[email protected]> * small uppercase/plural fixes * fixed Sevastopol boundary * Liechtenstein municipalities (#134) * Liechtenstein municipalities * added correct sparql * Update sources/ua/ukraine-regions.hjson Co-Authored-By: Nick Peihl <[email protected]> * Update sources/ua/ukraine-regions.hjson Co-Authored-By: Nick Peihl <[email protected]> * Update sources/ua/ukraine-regions.hjson Co-Authored-By: Nick Peihl <[email protected]> * Ukraine regions * fixed Sevastopol boundary * removed another label
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
The data was well and I didn't have to do anything special to get it using or regular SPARQL query.