[EuiDescriptionListTitle] Misc compressed style fixes (#7185)

elastic · Sep 14, 2023 · 3e0438a · 3e0438a
1 parent e46a21c
commit 3e0438a
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 11 deletions.
diff --git a/src/components/description_list/__snapshots__/description_list_title.test.tsx.snap b/src/components/description_list/__snapshots__/description_list_title.test.tsx.snap
@@ -26,7 +26,7 @@ exports[`EuiDescriptionListTitle EuiDescriptionListTitle prop variations type co
 
 exports[`EuiDescriptionListTitle EuiDescriptionListTitle prop variations type inline is rendered 1`] = `
 <dt
-  class="euiDescriptionList__title emotion-euiDescriptionList__title-inline-normal-s"
+  class="euiDescriptionList__title emotion-euiDescriptionList__title-inline-normal"
 />
 `;
 

diff --git a/src/components/description_list/description_list_title.styles.ts b/src/components/description_list/description_list_title.styles.ts
@@ -66,7 +66,8 @@ export const euiDescriptionListTitleStyles = (euiThemeContext: UseEuiTheme) => {
         ${logicalCSS('padding-horizontal', euiTheme.size.xs)}
       `,
       compressed: css`
-        ${euiFontSize(euiThemeContext, 'xs')}
+        font-size: ${euiFontSize(euiThemeContext, 'xs').fontSize};
+        line-height: ${euiTheme.font.lineHeightMultiplier};
         ${logicalCSS('padding-vertical', '0')}
         ${logicalCSS('padding-horizontal', euiTheme.size.xs)}
       `,

diff --git a/src/components/description_list/description_list_title.tsx b/src/components/description_list/description_list_title.tsx
@@ -40,7 +40,6 @@ export const EuiDescriptionListTitle: FunctionComponent<
       conditionalStyles = compressed
         ? [styles.inlineStyles.compressed]
         : [styles.inlineStyles.normal];
-      conditionalStyles.push(styles[rowGutterSize]);
       break;
     case 'row':
       conditionalStyles.push(styles[rowGutterSize]);

diff --git a/src/themes/amsterdam/overrides/_description_list.scss b/src/themes/amsterdam/overrides/_description_list.scss
diff --git a/src/themes/amsterdam/overrides/_index.scss b/src/themes/amsterdam/overrides/_index.scss
@@ -1,6 +1,5 @@
 @import 'combo_box';
 @import 'data_grid';
-@import 'description_list';
 @import 'form_control_layout';
 @import 'form_control_layout_delimited';
 @import 'form_controls';

diff --git a/upcoming_changelogs/7185.md b/upcoming_changelogs/7185.md
@@ -0,0 +1,4 @@
+**Bug fixes**
+
+- Fixed the inline compressed styles of `EuiDescriptionListTitle` to use a taller line-height for readability
+