[INFRA] Add command to stop running Buildkite jobs #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding a cancel_intermediate_jobs boolean to stop old jobs on PR update
|
@1Copenut can you push up a random commit to this PR and then revert it a minute later so we can see the cancel behavior working? |
Not this one, will have to try it after merging. Catalog changes are only scooped up by Terraform on the quarter hour in |
|
Ah whoops, gotcha. I guess YOLO in that case if we can't test it in the PR 😅 also hi @markjhoy, long time no see! |
cee-chen
approved these changes
Jul 27, 2023
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7006_buildkite/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_7006/ |
💚 Build Succeeded
cc @1Copenut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This job adds a
cancel_intermediate_jobs: trueboolean tocatalog-info.ymlto stop old jobs on PR update. I added the command to the combined PR test and deploy docs, as well as individual jobs so we get good coverage.I discussed this with @markjhoy as he's working on a same PR for Enterprise Search: https://github.com/elastic/ent-search/pull/7653
QA
I added the
cancel_intermediate_jobsboolean to all three jobs. Catalog changes have to be in main to get picked up by the Terraform task.I'll rapidly test this by updating the PR, after the fix is merged into main by changing things rapidly and changing them back to see if it cancels jobs correctly. Will make the PR history a little dirtier, but eh, squash and merge.