Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add callout to selection components with a link to selection components FAQ #7053

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

breehall
Copy link
Contributor

@breehall breehall commented Aug 7, 2023

Closes #6880

Summary

Adds documentation to the four selection components compared in The Ultimate Guide to EUI Selection Components FAQ pointing to the Github discussion.

QA

Check the following pages and ensure a callout with a link to the FAQ exists:

General checklist

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7053_buildkite/

Comment on lines 273 to 285
<EuiSpacer />
<EuiCallOut
iconType="questionInCircle"
title="Learn more about EUI selection components"
>
<p>
Can't decide which selection component to use? Checkout{' '}
<EuiLink href="https://github.com/elastic/eui/discussions/7049">
the ultimate guide to EUI's selection components{' '}
</EuiLink>
for in depth explanations and comparisons.
</p>
</EuiCallOut>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered creating a reusable variable for this, but decided against it because this content doesn't have a great place to live and it's strictly related to documentation.

@breehall breehall marked this pull request as ready for review August 7, 2023 20:43
@breehall breehall requested a review from cee-chen August 7, 2023 20:43
@breehall breehall requested a review from cee-chen August 8, 2023 18:34
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7053_buildkite/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7053_buildkite/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_7053_buildkite/

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with the back and forth on this Bree, and of course the great guide!

@breehall breehall merged commit 17ad68f into elastic:main Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Add better guidelines around which selection components to use, and when
4 participants