Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Bump .nvmrc to Node v18.18.0. #7276

Closed
wants to merge 1 commit into from

Conversation

1Copenut
Copy link
Contributor

Summary

PR follows #7274 that bumps Docker to use node-18.18.0-slim to set Node v18.18.0 as our daily driver for EUI.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

QA is a two-part manual process.

Part I
Pull the branch locally, then enter the following commands on your terminal:

  • nvm install 18.18.0
  • yarn you may see a Node warning about fsevents optional dependency error. This is b/c of our older Jest dep.
  • yarn lint
  • yarn test-unit
  • yarn test-cypress

Part II
When all of the following tests complete successfully:

  • nvm alias default 18.18.0
  • nvm uninstall 18.17.1

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @1Copenut

@1Copenut 1Copenut marked this pull request as ready for review October 10, 2023 22:09
@1Copenut 1Copenut requested a review from a team as a code owner October 10, 2023 22:09
@cee-chen
Copy link
Member

cee-chen commented Oct 10, 2023

Can we just merge/cherry-pick this into #7274? I'd rather not local CI and fall out of sync with each other, and I don't see a reason to split these up into separate PRs

@1Copenut
Copy link
Contributor Author

Closing this PR on @cee-chen suggestion to fold it into #7274.

@1Copenut 1Copenut closed this Oct 11, 2023
@1Copenut 1Copenut deleted the chore/daily-node-18.18.0 branch October 11, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants