Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tiers and subscription levels to capitalization rules #7323

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Add tiers and subscription levels to capitalization rules #7323

merged 6 commits into from
Oct 30, 2023

Conversation

florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Oct 27, 2023 •
edited
Loading

Summary

This PR is a follow-up to #7300.
It adds a mention of tiers and subscription levels to the capitalization rules of the writing section.

image

@florent-leborgne florent-leborgne requested a review from a team as a code owner October 27, 2023 16:00
@florent-leborgne
Copy link
Contributor Author

@gchaps @joepeeples FYI

@gchaps
Copy link
Contributor

gchaps commented Oct 27, 2023

LGTM. One minor suggestion is to add more examples to the box on the left.

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Oct 27, 2023
joepeeples
joepeeples reviewed Oct 27, 2023
View reviewed changes
Copy link

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a small edit to match the planned name for the Security tier. Thank you!

src-docs/src/views/guidelines/writing_guidelines.js Outdated Show resolved Hide resolved
cee-chen
cee-chen approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 lookin good to me from a code review perspective! not sure if you want to wait for more copy review from other folks, but feel free to merge whenever!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@florent-leborgne
Copy link
Contributor Author

@cee-chen Thanks. It seems that I no longer have permissions to merge on this repo. But the PR is ready to go, if you can please do it for me 🙏 :)

@cee-chen
Copy link
Member

Shoot sorry, I keep forgetting that! Merging!

@cee-chen cee-chen merged commit b1d7031 into elastic:main Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples left review comments

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@florent-leborgne @gchaps @kibanamachine @elasticmachine @cee-chen @joepeeples