High contrast mode #8036
Draft
High contrast mode #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
high-contrast-mode
branch
3 times, most recently
from
51185df
to
9fd8832
Compare
cee-chen
force-pushed
the
high-contrast-mode
branch
4 times, most recently
from
dd894de
to
f284850
Compare
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Nov 1, 2024
3 tasks
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Nov 4, 2024
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
Nov 7, 2024
- Prefer `modify` over computing at theme time, so that consumer modifications are also overridden and high contrast tokens are always enforced
- and set a border-bottom instead via box-shadow + code style cleanup - use optional chaining syntax instead of destructuring and correctly pass all options
+ fix file picker to correctly inherit border color, which is `lightShade` in any case in non-high-contrast mode
cee-chen
force-pushed
the
high-contrast-mode
branch
from
57c8ac4
to
fe464ed
Compare
- current theme relies *a lot* on background colors alone, which Windows high contrast themes completely ignores, so we need a lot of border workarounds here
- contrast feels low otherwise, especially for disabled inputs
+ DRY out `euiFormControlDefaultShadow` usage/unsets with newer API
cee-chen
force-pushed
the
high-contrast-mode
branch
2 times, most recently
from
54fe79d
to
2a62528
Compare
+ increase contrast of button group separators + add unique affordances for mac vs windows high contrast appearances
… high contrast mode - have to use actual `border` CSS and not `box-shadow` due to Windows + fix obvious components that require this - flyouts, modals, toasts, and mobile table rows
cee-chen
force-pushed
the
high-contrast-mode
branch
2 times, most recently
from
28f1786
to
90dfc63
Compare
- CSS cleanup: replace line-height with flex centering instead - this allows us to use borders of any thickness, and removes a lot of unnecessary vertical centering and tweaks (we can now remove all number styles completely) + remove background-image (which is ignored by Windows high contrast themes) in favor of a pseudo elementand border CSS + clean up horizontal focus rings
+ remove shadow on high contrast mode, it creates a weird border on Windows
…ows high contrast themes
+ simplify CSS selectors by using `:is()` instead of repeating `&` + address TODO
- requires a lot of SVG workarounds, since forced colors ignores background colors otherwise - rerun VRT snapshots for updates and verification
- requires using a lot of `<svg>` elements + improve thumbs in all high contrast modes
+ massive cleanup/refactor of src-docs theme context, prefer toggle for light/dark mode + remove defunct tour on language selector
… ThemeContext - might as well since we're already handling localStorage things there, saves us from waterfalling props unnecessarily
- at this point it's creating more false positives with nested template literals than it is being helpful
cee-chen
force-pushed
the
high-contrast-mode
branch
from
9e2742f
to
49b28f5
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @cee-chen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8133
See #7509 (comment)
Screenshots
Extra reading/reference:
QA
General checklist
@defaultif default values are missing) and playground toggles~-~ [ ] Checked Code Sandbox works for any docs examples
- [ ] Added or updated jest and cypress tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)