Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE][DRAFT] Theme color setup #8049

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Sep 26, 2024

Summary

closes #125

Important

This PR is currently still in Draft mode. It's based on this previous PR and relies on that one to be aligned and merged first.

🚧 TBA 🚧

Storybook: https://eui.elastic.co/pr_8049/storybook/
EUI docs: https://eui.elastic.co/pr_8049/#/
EUI+: https://eui.elastic.co/pr_8049/new-docs/

QA

🚧 TBA 🚧

- externally created, compiled and imported themes don't pass the class check anymore we can check for the shape additionally
- theme contains only cloned values from current theme
-removes circle dependency on main eui
build: ensure sass files are added to packed sub packages
- this is a first step, once the overall path si defined we either need to continue moving out more or reverse this partially
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants