Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTabs] Fix link tabs incorrectly wrapping #8073

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Oct 14, 2024

Summary

🤦 I fixed this for <button> tab content in #7309 but missed link tabs. Originally broken in #6311

Before:

After

QA

General checklist

  • Browser QA
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked for accessibility including keyboard-only and screenreader modes
      - [ ] Checked in both light and dark modes
  • Docs site QA - N/A, style bugfix
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
      - [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist - N/A

@cee-chen cee-chen marked this pull request as ready for review October 14, 2024 20:44
@cee-chen cee-chen requested a review from a team as a code owner October 14, 2024 20:44
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ Works as expected!

@cee-chen cee-chen merged commit 59a70df into elastic:main Oct 15, 2024
6 checks passed
@cee-chen cee-chen deleted the tab-wrap-fix branch October 15, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants