Support for decoding string/date-time to time.Time #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support decoding string/date-time in the json schema to a time.Time in golang. This is done by adding a new internal attribute that will track additional (golang) imports that a struct needs to import for code generation.
ph
reviewed
May 18, 2022
There was a problem hiding this comment.
this lgtm but @aleksmaus you know more the code than me.
Also we have forked that repository, should we try to push our changes upstream?
|
@ph we hacked a bunch of customizations together there for our purposes, some as far as I remember are incompatible with the original generator and some stuff we no longer use. need to see what would it take to clean it up and if that would be compatible with upstream at this point. |
|
Thanks for the details, I don't see a great rush to push it upstream. |
ph
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support decoding string/date-time in the json schema to a time.Time in
golang. This is done by adding a new internal attribute that will track
additional (golang) imports that a struct needs to import for code
generation.