Skip to content

Commit

Permalink
Use ECS recommended values for network direction (#76)
Browse files Browse the repository at this point in the history
* Use ECS recommended values for network direction

- change incoming -> inbound
- change outgoing -> outbound

Closes #75
  • Loading branch information
leehinman authored Aug 18, 2020
1 parent b25dae8 commit 09d6008
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 14 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).

### Changed

- Use ECS recommended values for network direction. [#75](https://github.com/elastic/go-libaudit/issues/75)[#76](https://github.com/elastic/go-libaudit/pull/76)

### Removed

- Remove github.com/Sirupsen/logrus dependency from examples. [#73]https://github.com/elastic/go-libaudit/issues/73
- Remove github.com/Sirupsen/logrus dependency from examples. [#73](https://github.com/elastic/go-libaudit/issues/73)

### Deprecated

Expand Down Expand Up @@ -191,4 +193,4 @@ This project adheres to [Semantic Versioning](http://semver.org/).
[0.0.4]: https://github.com/elastic/go-libaudit/releases/tag/v0.0.4
[0.0.3]: https://github.com/elastic/go-libaudit/releases/tag/v0.0.3
[0.0.2]: https://github.com/elastic/go-libaudit/releases/tag/v0.0.2
[0.0.1]: https://github.com/elastic/go-libaudit/releases/tag/v0.0.1
[0.0.1]: https://github.com/elastic/go-libaudit/releases/tag/v0.0.1
4 changes: 2 additions & 2 deletions aucoalesce/coalesce.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ const (
func (d Direction) String() string {
switch d {
case IncomingDir:
return "incoming"
return "inbound"
case OutgoingDir:
return "outgoing"
return "outbound"
}
return "unknown"
}
Expand Down
6 changes: 3 additions & 3 deletions aucoalesce/testdata/rhel-7-linux-3.10.0.json.golden
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"ip": "96.241.146.97"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"fp": "6d:a3:7f:ed:de:4a:79:f2:aa:49:ec:d1:75:36:97:a3",
Expand Down Expand Up @@ -204,7 +204,7 @@
"ip": "96.241.146.97"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"cipher": "[email protected]",
Expand Down Expand Up @@ -324,7 +324,7 @@
"ip": "46.160.144.250"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"acct": "root",
Expand Down
10 changes: 5 additions & 5 deletions aucoalesce/testdata/ubuntu-16.10-linux-4.8.0.json.golden
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@
"ip": "179.38.151.221"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"acct": "(invalid user)",
Expand Down Expand Up @@ -517,7 +517,7 @@
"ip": "72.83.230.100"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"hostname": "72.83.230.100",
Expand Down Expand Up @@ -573,7 +573,7 @@
"ip": "72.83.230.100"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"acct": "andrew_kroh",
Expand Down Expand Up @@ -643,7 +643,7 @@
"port": "58140"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"a0": "3",
Expand Down Expand Up @@ -786,7 +786,7 @@
"port": "80"
},
"network": {
"direction": "outgoing"
"direction": "outbound"
},
"data": {
"a0": "5",
Expand Down
4 changes: 2 additions & 2 deletions aucoalesce/testdata/ubuntu-17.04-linux-4.10.0.json.golden
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
"ip": "185.56.82.22"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"hostname": "185.56.82.22",
Expand Down Expand Up @@ -549,7 +549,7 @@
"ip": "31.207.47.36"
},
"network": {
"direction": "incoming"
"direction": "inbound"
},
"data": {
"acct": "(invalid user)",
Expand Down

0 comments on commit 09d6008

Please sign in to comment.