Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify cadence of updates to EPR image #1214

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Jul 30, 2024

As stated by @mrodm, we update the docker images every time a new version of a package gets published.

It's important to highlight this detail for users in air-gapped envs.

This should be backported to any version.

@lucabelluccini lucabelluccini requested a review from a team as a code owner July 30, 2024 14:29
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link

mergify bot commented Jul 30, 2024

This pull request does not have a backport label. Could you fix it @lucabelluccini? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

jsoriano
jsoriano previously approved these changes Jul 30, 2024
kilfoyle
kilfoyle previously approved these changes Jul 30, 2024
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this @lucabelluccini!
Once the CI checks pass I'll merge it and backport it into the current docs.

shainaraskas
shainaraskas previously approved these changes Jul 30, 2024
mrodm
mrodm previously approved these changes Jul 30, 2024
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestion inline for consideration.

docs/en/ingest-management/fleet/air-gapped.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/air-gapped.asciidoc Outdated Show resolved Hide resolved
@kilfoyle kilfoyle dismissed stale reviews from mrodm, shainaraskas, and themself via 3be67cb July 30, 2024 16:39
@kilfoyle kilfoyle requested a review from karenzone July 30, 2024 16:40
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 7632880 into elastic:main Jul 30, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
* [DOCS] Clarify cadence of updates to EPR image

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

---------

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
(cherry picked from commit 7632880)
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
* [DOCS] Clarify cadence of updates to EPR image

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

---------

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
(cherry picked from commit 7632880)
kilfoyle pushed a commit that referenced this pull request Jul 30, 2024
* [DOCS] Clarify cadence of updates to EPR image

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

---------

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
(cherry picked from commit 7632880)

Co-authored-by: Luca Belluccini <[email protected]>
kilfoyle pushed a commit that referenced this pull request Jul 30, 2024
* [DOCS] Clarify cadence of updates to EPR image

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

* Update docs/en/ingest-management/fleet/air-gapped.asciidoc

Co-authored-by: Karen Metts <[email protected]>

---------

Co-authored-by: David Kilfoyle <[email protected]>
Co-authored-by: Karen Metts <[email protected]>
(cherry picked from commit 7632880)

Co-authored-by: Luca Belluccini <[email protected]>
@lucabelluccini lucabelluccini deleted the patch-2 branch July 31, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants