Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][MSSQL] Add mssql.query field to transaction_logs data stream for debug purposes #12216

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Jan 1, 2025

  • Enhancement

Proposed commit message

  • Add preserve_sql_queries flag to transaction_log data stream that can be used as preserve sql.query field, if it's enabled.
  • Generate system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

  • Debug Flag

debug-flag

  • Debug Flag Enabled Event

with-debug-flag-event

  • Debug Flag Disabled Event

without-debug-flag-event

@harnish-elastic harnish-elastic added enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jan 1, 2025
@harnish-elastic harnish-elastic self-assigned this Jan 1, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@harnish-elastic harnish-elastic requested a review from shmsr January 16, 2025 04:49
@shmsr
Copy link
Member

shmsr commented Jan 16, 2025

Make this PR consistent with #12212

@harnish-elastic
Copy link
Contributor Author

Make this PR consistent with #12212

Updated, thanks!

@shmsr
Copy link
Member

shmsr commented Jan 17, 2025

Can we make it 2.10.1 instead of 2.11? Rest looks good!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@harnish-elastic harnish-elastic merged commit 038024e into elastic:main Jan 17, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package microsoft_sqlserver - 2.10.1 containing this change is available at https://epr.elastic.co/package/microsoft_sqlserver/2.10.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants