Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity test run for OBS top 5 integration packages for 9.0.0 #12251

Merged
merged 9 commits into from
Jan 20, 2025

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Jan 8, 2025

  • Enhancement

Description

Based on the email from @jsoriano tested and updated the top 5 packages for 9.0.0 enablement activities of O11y integrations.

Steps performed for the testing

  1. update manifest.yml, package minor version upgrade and kibana dependency addition || ^9.0.0.
  2. build package
  3. run package tests
  4. install integration from kibana
  5. check for any issues

Nginx

  • tested for elastic stack and server-less.
  • datastreams access, error, and stubstatus are tested as part of the sanity.
  Metrics Logs Dashboards
Elastic Stack Pass Pass Pass
Server-less Pass Pass Pass

MySQL

  • tested for elastic stack and server-less.
  • datastreams error, galera_status, performance, replica_status, slowlog, and status are tested as part of the sanity.
  Metrics Logs Dashboards
Elastic Stack Pass Pass Pass
Server-less Pass Pass Pass

Google Cloud

  • tested for elastic stack.
  • datastreams access, error, and stubstatus are tested as part of the sanity.
  Metrics Logs Dashboards Test Cases
Elastic Stack Pass Pass Pass Fail

IIS

  • tested for elastic stack and server-less.
  • datastreams access, application_pool, error, webserver, and website are tested as part of the sanity.
  Metrics Logs Dashboards
Elastic Stack Pass Pass Pass
Server-less Pass Pass Pass

System

  • tested for elastic stack and server-less.
  • datastreams application, core, diskio, fsstat, memory, process, security, syslog, uptime, auth, cpu, filesystem, load, network, process_summary, socket_summary, and system are tested as part of the sanity.
  Metrics Logs Dashboards
Elastic Stack Pass Pass Pass
Server-less Pass Pass Pass

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@kush-elastic kush-elastic requested a review from a team as a code owner January 8, 2025 05:40
@kush-elastic kush-elastic changed the title nginx sanity test for 9.0.0 support [Nginx] Sanity tests for 9.0.0 Jan 8, 2025
@kush-elastic kush-elastic self-assigned this Jan 8, 2025
@kush-elastic kush-elastic added enhancement New feature or request Integration:nginx Nginx labels Jan 8, 2025
@andrewkroh andrewkroh added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jan 8, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 8, 2025

🚀 Benchmarks report

Package gcp 👍(0) 💚(3) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dns 2890.17 2444.99 -445.18 (-15.4%) 💔
loadbalancing_logs 3787.88 3003 -784.88 (-20.72%) 💔
vpcflow 5050.51 3508.77 -1541.74 (-30.53%) 💔

Package mysql 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
slowlog 30303.03 20833.33 -9469.7 (-31.25%) 💔

Package system 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
syslog 250000 166666.67 -83333.33 (-33.33%) 💔

To see the full report comment with /test benchmark fullreport

@kush-elastic kush-elastic requested review from a team as code owners January 8, 2025 10:06
@kush-elastic kush-elastic changed the title [Nginx] Sanity tests for 9.0.0 Sanity test run for OBS top 5 integration packages for 9.0.0 Jan 8, 2025
@@ -1,2 +1,4 @@
fields:
input.type: log
dynamic_fields:
"@timestamp": "^[0-9]{4}(-[0-9]{2}){2}T[0-9]{2}(:[0-9]{2}){2}\\.[0-9]{3}Z$"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break without these changes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,
The issue is with the pipeline config file where we need to define: dynamic_fields: "@timestamp": "^[0-9]{4}(-[0-9]{2}){2}T[0-9]{2}(:[0-9]{2}){2}\\.[0-9]{3}Z$"
Above mentioned regex will allow all years in the @timestamp. Right now, it is missing in our config file, causing the pipeline to fail for two specific files.

@kush-elastic
Copy link
Collaborator Author

/test

@kush-elastic
Copy link
Collaborator Author

/test

@andrewkroh andrewkroh added Integration:gcp Google Cloud Platform Integration:iis IIS Integration:mysql MySQL Integration:system System Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Jan 13, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.41.0"
changes:
- description: Upgrade to Kibana `9.0.0`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can we make it clearer that this is not an upgrade per-se, but that we are marking these packages as supported on kibana 9.0+

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.21.0"
changes:
- description: Upgrade to Kibana `9.0.0`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Upgrade to Kibana `9.0.0`.
- description: Add support for Kibana `9.0.0`.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kush-elastic

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kush-elastic kush-elastic merged commit cbfba9e into elastic:main Jan 20, 2025
5 checks passed
@elastic-vault-github-plugin-prod

Package gcp - 2.41.0 containing this change is available at https://epr.elastic.co/package/gcp/2.41.0/

@elastic-vault-github-plugin-prod

Package iis - 1.21.0 containing this change is available at https://epr.elastic.co/package/iis/1.21.0/

@elastic-vault-github-plugin-prod

Package mysql - 1.26.0 containing this change is available at https://epr.elastic.co/package/mysql/1.26.0/

@elastic-vault-github-plugin-prod

Package nginx - 1.25.0 containing this change is available at https://epr.elastic.co/package/nginx/1.25.0/

@elastic-vault-github-plugin-prod

Package system - 1.64.0 containing this change is available at https://epr.elastic.co/package/system/1.64.0/

@@ -1,2 +1,4 @@
fields:
input.type: log
dynamic_fields:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encourage to add these details in the integration developer guidelines, provided this situation may cause issues in other integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:gcp Google Cloud Platform Integration:iis IIS Integration:mysql MySQL Integration:nginx Nginx Integration:system System Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants