-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rubrik] Add physical_hosts
data stream
#12289
Conversation
- name: rubrik.physical_hosts | ||
type: group | ||
fields: | ||
- name: id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to get more clarity on the field name. Do we need to name it asphysical_hosts.node.id
or just physical_hosts.id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A node is part of the GraphQL structure: an edge represents the connection between the parent object and the list of items and the node represents the actual item in the list, the node in this case is a physical host.
"connectivity": "DISCONNECTED" | ||
}, | ||
"os_type": "WINDOWS", | ||
"name": "0.0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the name include the host IP address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the official description "Name of the hierarchy object.". Not sure why it's an IP address but it's not specified as the host IP address.
🚀 Benchmarks reportTo see the full report comment with |
minor fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
💚 Build Succeeded
History
cc @gpop63 |
Quality Gate failedFailed conditions |
Overview
This PR adds
physical_hosts
data stream. Uses CEL input to make 2 independent requests to the GraphQL API.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots