Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rubrik] Add physical_hosts data stream #12289

Merged
merged 17 commits into from
Jan 16, 2025

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jan 9, 2025

Overview

This PR adds physical_hosts data stream. Uses CEL input to make 2 independent requests to the GraphQL API.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

  • Closes elastic/obs-integration-team/issues/116

Screenshots

@gpop63 gpop63 self-assigned this Jan 9, 2025
@gpop63 gpop63 added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] New Integration Issue or pull request for creating a new integration package. Integration:rubrik Rubrik RSC Metrics enhancement New feature or request labels Jan 9, 2025
@gpop63 gpop63 marked this pull request as ready for review January 9, 2025 19:18
@gpop63 gpop63 requested a review from a team as a code owner January 9, 2025 19:18
packages/rubrik/data_stream/physical_hosts/manifest.yml Outdated Show resolved Hide resolved
- name: rubrik.physical_hosts
type: group
fields:
- name: id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to get more clarity on the field name. Do we need to name it asphysical_hosts.node.idor just physical_hosts.id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A node is part of the GraphQL structure: an edge represents the connection between the parent object and the list of items and the node represents the actual item in the list, the node in this case is a physical host.

"connectivity": "DISCONNECTED"
},
"os_type": "WINDOWS",
"name": "0.0.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the name include the host IP address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the official description "Name of the hierarchy object.". Not sure why it's an IP address but it's not specified as the host IP address.

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @gpop63

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
47.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@gpop63 gpop63 merged commit 87fddab into elastic:main Jan 16, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:rubrik Rubrik RSC Metrics New Integration Issue or pull request for creating a new integration package. Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants