Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSSQL] TSDB enabled release. #6181

Merged
merged 6 commits into from
Jun 27, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented May 12, 2023

  • Enhancement

What does this PR do?

This PR enables beta testing of MSSQL package for TSDB. The package has been already migrated with dimension and metric type mapping. Here it enables index_mode: "time_series" for MSSQL performance and transaction_log data stream and also upgrades stack version to 8.8.0.

Package version made -beta to avoid accidental use from other users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Load 8.8.0+ stack
Add mssql config.
Load latest package locally/cloud and follow detailed testing plan.

Related issues

@elasticmachine
Copy link

elasticmachine commented May 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-26T07:40:04.203+0000

  • Duration: 17 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.769
Classes 100.0% (2/2) 💚 2.769
Methods 93.75% (30/32) 👍 0.61
Lines 100.0% (1251/1251) 💚 8.415
Conditionals 100.0% (0/0) 💚

@botelastic
Copy link

botelastic bot commented Jun 11, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 11, 2023
@ritalwar ritalwar changed the title [MSSQL] Enabling TSDB on MSSQL for beta testing. [MSSQL] TSDB enabled release. Jun 26, 2023
@botelastic botelastic bot removed the Stalled label Jun 26, 2023
@ritalwar ritalwar marked this pull request as ready for review June 26, 2023 07:19
@ritalwar ritalwar requested a review from a team as a code owner June 26, 2023 07:19
@ritalwar ritalwar mentioned this pull request Jun 26, 2023
11 tasks
@lalit-satapathy
Copy link
Collaborator

LGTM

@ritalwar ritalwar merged commit a2333d5 into elastic:main Jun 27, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@andrewkroh andrewkroh added the Integration:microsoft_sqlserver Microsoft SQL Server label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants