[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221

constanca-m · 2023-05-16T09:58:25Z

What does this PR do?

Fixes an incorrect visualization:

That is present in both scheduler and proxy dashboards.

It should work as expected now:

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Signed-off-by: constanca-m <[email protected]>

tetianakravchenko · 2023-05-16T10:11:52Z

packages/kubernetes/changelog.yml

@@ -9,6 +9,11 @@
    - description: Remove container.name as a dimension.
      type: enhancement
      link: https://github.com/elastic/integrations/pull/6209
+- version: "1.38.2"


I think we should use 1.39.1, I believe 1.39.0 will not be rebuild after merging this PR, and 1.39.0 will not include those changes

Interesting, I did not know that. I will update to 1.39.1 then

@jsoriano could you please double-check this? is my assumption correct regarding the package version rebuilds?

Any new version would be published on merge, so if none of them are published, then both would work in that regard.
Said that, I would go with the proposal of using 1.39.1, so you can still reserve 1.38.X for backports to this minor if needed at some point.

If you need this fix in 1.38 for some reason, I would suggest to merge it first as 1.39.1, and after that follow this procedure to release a 1.38.2 version: https://github.com/elastic/integrations/blob/ce78cfe4a13c14528bb88b809d7ed2789dd1b2ab/docs/developer_workflow_bug_fix_older_package_version.md

@jsoriano there were no kibana restrictions introduces, so it should be fine to go with 1.39.1
the issue here is: the latest version is version: "1.40.0-beta", is it possible to rebuild 1.40.0-beta after publishing 1.39.1 with this changes? or there should be created 1.40.1-beta (with those changes) first and backported to the 1.39.1?

Oh ok, I was overlooking these changes for 1.40. If you merge this change as is now, it will publish a 1.39.1 version that will include #6159. You probably don't want that.

So I think you need to:

On this PR, start a new version in the changelog, for example 1.40.0-beta.1. And move the new changelog entry there.

Once merged, it will release 1.40.0-beta.1 with this fix.

Then follow this procedure to backport the fix to 1.39.

You can introduce further changes on the prerelease numbering the qualifiers, with beta.1, beta.2 and so on.

If you want to introduce multiple changes in 1.40.0, but don't trigger publication of packages, you can use the next qualifier (so it would be 1.40.0-next). You can read more about this approach in https://github.com/elastic/integrations/blob/ce78cfe4a13c14528bb88b809d7ed2789dd1b2ab/docs/developer_workflow_design_build_test_integration.md#remember-to-bump-up-the-version.

thank you for the clarifications on the process!

Signed-off-by: constanca-m <[email protected]>

elasticmachine · 2023-05-16T10:27:40Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-05-16T13:54:47.350+0000
Duration: 29 min 59 sec

Test stats 🧪

Test	Results
Failed	0
Passed	92
Skipped	0
Total	92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-05-16T10:27:50Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 10.87
Classes	100.0% (`0/0`)	💚 10.87
Methods	96.154% (`75/78`)	👍 7.324
Lines	100.0% (`0/0`)	💚 11.972
Conditionals	100.0% (`0/0`)	💚

Signed-off-by: constanca-m <[email protected]>

packages/kubernetes/changelog.yml

Co-authored-by: Jaime Soriano Pastor <[email protected]>

Signed-off-by: constanca-m <[email protected]>

tetianakravchenko

Tested upgrade 1.39.0 to 1.40.0-beta.1 locally - corresponding visualizations do no have Sort field was not found. errors

elasticmachine · 2023-05-17T08:15:40Z

Package kubernetes - 1.40.0-beta.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes

…r dashboards (elastic#6221) * Fix dashboards. Signed-off-by: constanca-m <[email protected]> * Update changelog. Signed-off-by: constanca-m <[email protected]> * Rollback state node. Signed-off-by: constanca-m <[email protected]> * Rollback container logs. Signed-off-by: constanca-m <[email protected]> * Update package version. Signed-off-by: constanca-m <[email protected]> * Update version. Signed-off-by: constanca-m <[email protected]> * Update packages/kubernetes/changelog.yml Co-authored-by: Jaime Soriano Pastor <[email protected]> * Update version. Signed-off-by: constanca-m <[email protected]> --------- Signed-off-by: constanca-m <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>

…r dashboards (#6221) (#6237) * Fix dashboards. * Update changelog. * Rollback state node. * Rollback container logs. * Update package version. * Update version. * Update packages/kubernetes/changelog.yml * Update version. --------- Signed-off-by: constanca-m <[email protected]> Co-authored-by: Constança Manteigas <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>

elasticmachine · 2023-05-17T16:04:53Z

Package kubernetes - 1.39.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Fix dashboards.

f3e8444

Signed-off-by: constanca-m <[email protected]>

constanca-m added the Integration:kubernetes Kubernetes label May 16, 2023

constanca-m requested a review from tetianakravchenko May 16, 2023 09:58

constanca-m self-assigned this May 16, 2023

constanca-m requested review from a team as code owners May 16, 2023 09:58

constanca-m requested a review from gsantoro May 16, 2023 09:58

constanca-m added 3 commits May 16, 2023 11:58

Update changelog.

a9d9f97

Signed-off-by: constanca-m <[email protected]>

Rollback state node.

2334231

Signed-off-by: constanca-m <[email protected]>

Rollback container logs.

6925560

Signed-off-by: constanca-m <[email protected]>

tetianakravchenko reviewed May 16, 2023

View reviewed changes

Update package version.

6c262ef

Signed-off-by: constanca-m <[email protected]>

Update version.

e164ef8

Signed-off-by: constanca-m <[email protected]>

jsoriano reviewed May 16, 2023

View reviewed changes

packages/kubernetes/changelog.yml Outdated Show resolved Hide resolved

constanca-m and others added 2 commits May 16, 2023 15:53

Update packages/kubernetes/changelog.yml

5e21cd6

Co-authored-by: Jaime Soriano Pastor <[email protected]>

Update version.

4ac89a8

Signed-off-by: constanca-m <[email protected]>

tetianakravchenko requested a review from lalit-satapathy May 16, 2023 15:33

tetianakravchenko approved these changes May 16, 2023

View reviewed changes

tetianakravchenko merged commit 2e7c914 into elastic:main May 17, 2023

constanca-m deleted the fix-k8s-dashboards branch May 17, 2023 07:53

constanca-m mentioned this pull request May 17, 2023

[Kubernetes] Update version to fix bug on scheduler and proxy dashboards #6233

Closed

4 tasks

tetianakravchenko mentioned this pull request May 17, 2023

[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6237

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221

[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221

constanca-m commented May 16, 2023

tetianakravchenko May 16, 2023

constanca-m May 16, 2023

tetianakravchenko May 16, 2023

jsoriano May 16, 2023

tetianakravchenko May 16, 2023

jsoriano May 16, 2023

tetianakravchenko May 16, 2023

elasticmachine commented May 16, 2023 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented May 16, 2023 •

edited

Loading

tetianakravchenko left a comment

elasticmachine commented May 17, 2023

elasticmachine commented May 17, 2023

[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221

[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221

Conversation

constanca-m commented May 16, 2023

What does this PR do?

Checklist

tetianakravchenko May 16, 2023

Choose a reason for hiding this comment

constanca-m May 16, 2023

Choose a reason for hiding this comment

tetianakravchenko May 16, 2023

Choose a reason for hiding this comment

jsoriano May 16, 2023

Choose a reason for hiding this comment

tetianakravchenko May 16, 2023

Choose a reason for hiding this comment

jsoriano May 16, 2023

Choose a reason for hiding this comment

tetianakravchenko May 16, 2023

Choose a reason for hiding this comment

elasticmachine commented May 16, 2023 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented May 16, 2023 • edited Loading

🌐 Coverage report

tetianakravchenko left a comment

Choose a reason for hiding this comment

elasticmachine commented May 17, 2023

elasticmachine commented May 17, 2023

elasticmachine commented May 16, 2023 •

edited

Loading

elasticmachine commented May 16, 2023 •

edited

Loading