-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221
[Kubernetes][Dashboards] Fix missing sort field on proxy and scheduler dashboards #6221
Conversation
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
Signed-off-by: constanca-m <[email protected]>
packages/kubernetes/changelog.yml
Outdated
@@ -9,6 +9,11 @@ | |||
- description: Remove container.name as a dimension. | |||
type: enhancement | |||
link: https://github.com/elastic/integrations/pull/6209 | |||
- version: "1.38.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use 1.39.1
, I believe 1.39.0
will not be rebuild after merging this PR, and 1.39.0 will not include those changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I did not know that. I will update to 1.39.1 then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano could you please double-check this? is my assumption correct regarding the package version rebuilds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any new version would be published on merge, so if none of them are published, then both would work in that regard.
Said that, I would go with the proposal of using 1.39.1
, so you can still reserve 1.38.X
for backports to this minor if needed at some point.
If you need this fix in 1.38 for some reason, I would suggest to merge it first as 1.39.1
, and after that follow this procedure to release a 1.38.2
version: https://github.com/elastic/integrations/blob/ce78cfe4a13c14528bb88b809d7ed2789dd1b2ab/docs/developer_workflow_bug_fix_older_package_version.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano there were no kibana restrictions introduces, so it should be fine to go with 1.39.1
the issue here is: the latest version is version: "1.40.0-beta"
, is it possible to rebuild 1.40.0-beta
after publishing 1.39.1
with this changes? or there should be created 1.40.1-beta
(with those changes) first and backported to the 1.39.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, I was overlooking these changes for 1.40. If you merge this change as is now, it will publish a 1.39.1
version that will include #6159. You probably don't want that.
So I think you need to:
- On this PR, start a new version in the changelog, for example
1.40.0-beta.1
. And move the new changelog entry there. - Once merged, it will release
1.40.0-beta.1
with this fix. - Then follow this procedure to backport the fix to 1.39.
You can introduce further changes on the prerelease numbering the qualifiers, with beta.1, beta.2 and so on.
If you want to introduce multiple changes in 1.40.0
, but don't trigger publication of packages, you can use the next
qualifier (so it would be 1.40.0-next
). You can read more about this approach in https://github.com/elastic/integrations/blob/ce78cfe4a13c14528bb88b809d7ed2789dd1b2ab/docs/developer_workflow_design_build_test_integration.md#remember-to-bump-up-the-version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the clarifications on the process!
Signed-off-by: constanca-m <[email protected]>
🌐 Coverage report
|
Signed-off-by: constanca-m <[email protected]>
Co-authored-by: Jaime Soriano Pastor <[email protected]>
Signed-off-by: constanca-m <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested upgrade 1.39.0
to 1.40.0-beta.1
locally - corresponding visualizations do no have Sort field was not found.
errors
Package kubernetes - 1.40.0-beta.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
…r dashboards (elastic#6221) * Fix dashboards. Signed-off-by: constanca-m <[email protected]> * Update changelog. Signed-off-by: constanca-m <[email protected]> * Rollback state node. Signed-off-by: constanca-m <[email protected]> * Rollback container logs. Signed-off-by: constanca-m <[email protected]> * Update package version. Signed-off-by: constanca-m <[email protected]> * Update version. Signed-off-by: constanca-m <[email protected]> * Update packages/kubernetes/changelog.yml Co-authored-by: Jaime Soriano Pastor <[email protected]> * Update version. Signed-off-by: constanca-m <[email protected]> --------- Signed-off-by: constanca-m <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>
…r dashboards (#6221) (#6237) * Fix dashboards. * Update changelog. * Rollback state node. * Rollback container logs. * Update package version. * Update version. * Update packages/kubernetes/changelog.yml * Update version. --------- Signed-off-by: constanca-m <[email protected]> Co-authored-by: Constança Manteigas <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]>
Package kubernetes - 1.39.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
What does this PR do?
Fixes an incorrect visualization:
That is present in both scheduler and proxy dashboards.
It should work as expected now:
Checklist
changelog.yml
file.