-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix system test for kubernetes integration for k8s v1.27.0 #6310
Conversation
Hey @jsoriano, does merging this commit overwrite the beta versions in Kubernetes package? Beta versions are in 1.40.0 versions as well. |
🌐 Coverage report
|
The 1.40.0 will be published and beta versions will remain published too. Search requests will start including 1.40.0. |
@@ -25,6 +25,7 @@ streams: | |||
title: Dataset name | |||
description: > | |||
Set the name for your dataset. Changing the dataset will send the data to a different index. For more info look at [data_stream field](https://www.elastic.co/guide/en/ecs/master/ecs-data_stream.html). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this line added? Same for the next file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the output of elastic-package format
or elastic-package lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange. Because there is not empty line under all fields. Personally I wouldn't leave this line but it's your choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to update the K8s package version again since 1.41 exists now.
You're right, when I saw it was pushed I though it had been committed as well. Sorry, my mistake :) |
Package kubernetes - 1.40.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
What does this PR do?
Fix failing system tests for the integration kubernetes when testing with kubernetes > v1.27.0.
It fails with the following error
I tried to just upgrade the version of container image
k8s.gcr.io/nginx-slim:0.8
to a newer tag but since I couldn't easily list the tags available (like I would do with docker hub) I couldn't really figure out the Dockerfile related to that image or what was wrong with that image. Questions on stackoverflow about this error seems to suggest that the official image of nginx doesn't come with Lua at all.Also because of announcement I tried to replace the container registry from k8s.gcr.io to registry.k8s.io but I had a similar problem trying to figure out what was the latest version of nginx image at that container registry.
So the solution was to use an official nginx image from dockerhub. That was enough to fix the issue and make all system tests pass.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots