Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSphere] Tsdb enabled release #6693

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Jun 26, 2023

  • Enhancement

What does this PR do?

This PR enables TSDB for Vsphere.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar requested a review from a team as a code owner June 26, 2023 07:45
@elasticmachine
Copy link

elasticmachine commented Jun 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-29T08:42:02.743+0000

  • Duration: 17 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.481
Classes 100.0% (1/1) 💚 3.481
Methods 100.0% (18/18) 💚 10.748
Lines 89.13% (41/46) 👎 -2.842
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar mentioned this pull request Jun 26, 2023
16 tasks
@lalit-satapathy
Copy link
Collaborator

@ritalwar, There are changes related to sample event. Could you please summarise, whats triggering it?

@ritalwar
Copy link
Contributor Author

@ritalwar, There are changes related to sample event. Could you please summarise, whats triggering it?

I ran tests on this package with --generate command, which updated the sample_events.

@lalit-satapathy
Copy link
Collaborator

@ritalwar, There are changes related to sample event. Could you please summarise, whats triggering it?

I ran tests on this package with --generate command, which updated the sample_events.

@ishleenk17 can you review the sample event changes, is this expected?

@ishleenk17
Copy link
Contributor

ishleenk17 commented Jun 28, 2023

@ritalwar, There are changes related to sample event. Could you please summarise, whats triggering it?

I ran tests on this package with --generate command, which updated the sample_events.

@ishleenk17 can you review the sample event changes, is this expected?

Yes these are expected. Just a question regarding ecs version that I wanted to clarify.

@lalit-satapathy
Copy link
Collaborator

@ritalwar, There are changes related to sample event. Could you please summarise, whats triggering it?

I ran tests on this package with --generate command, which updated the sample_events.

@ishleenk17 can you review the sample event changes, is this expected?

Yes these are expected. Just a question regarding ecs version that I wanted to clarify.

Is this thread closed now?

@ishleenk17
Copy link
Contributor

@ritalwar, There are changes related to sample event. Could you please summarise, whats triggering it?

I ran tests on this package with --generate command, which updated the sample_events.

@ishleenk17 can you review the sample event changes, is this expected?

Yes these are expected. Just a question regarding ecs version that I wanted to clarify.

Is this thread closed now?

Yes, we can close this thread now.

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved changes from non-TSDB perspective.

@ritalwar ritalwar merged commit e46aa89 into elastic:main Jul 6, 2023
@elasticmachine
Copy link

Package vsphere - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=vsphere

gizas pushed a commit that referenced this pull request Sep 5, 2023
* [VSphere] Tsdb enabled release
@andrewkroh andrewkroh added the Integration:vsphere VMware vSphere label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:vsphere VMware vSphere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants