Skip to content

Commit

Permalink
[8.x] [Security Solution][Notes] - fix the notes link that is shown t…
Browse files Browse the repository at this point in the history
…wice in the search bar (#198200) (#198255)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Notes] - fix the notes link that is shown twice
in the search bar
(#198200)](#198200)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T08:33:04Z","message":"[Security
Solution][Notes] - fix the notes link that is shown twice in the search
bar (#198200)\n\n## Summary\r\n\r\nThis PR fixes a minor inconvenience
where the Kibana search bar was\r\nshowing 2 entries for the new Notes
management page.\r\n\r\n| Before fix | After fix |\r\n| ------------- |
------------- |\r\n| ![Screenshot 2024-10-29 at 11
53\r\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\r\n|
![Screenshot 2024-10-29 at 11
53\r\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\r\n|\r\n\r\nNotes:
this fix does not fix an issue happening in the
space-specific\r\nsearch, where Notes, Timelines and maybe other entries
are appearing\r\ntwice. That issue seems to be related to the way we are
removing then\r\nadding back links to work with the new navigation. I
looked into it but\r\ncould not find a way to fix yet, so this will be
part of a follow up
PR\r\n\r\nhttps://github.com//issues/197694","sha":"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
fix the notes link that is shown twice in the search
bar","number":198200,"url":"https://github.com/elastic/kibana/pull/198200","mergeCommit":{"message":"[Security
Solution][Notes] - fix the notes link that is shown twice in the search
bar (#198200)\n\n## Summary\r\n\r\nThis PR fixes a minor inconvenience
where the Kibana search bar was\r\nshowing 2 entries for the new Notes
management page.\r\n\r\n| Before fix | After fix |\r\n| ------------- |
------------- |\r\n| ![Screenshot 2024-10-29 at 11
53\r\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\r\n|
![Screenshot 2024-10-29 at 11
53\r\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\r\n|\r\n\r\nNotes:
this fix does not fix an issue happening in the
space-specific\r\nsearch, where Notes, Timelines and maybe other entries
are appearing\r\ntwice. That issue seems to be related to the way we are
removing then\r\nadding back links to work with the new navigation. I
looked into it but\r\ncould not find a way to fix yet, so this will be
part of a follow up
PR\r\n\r\nhttps://github.com//issues/197694","sha":"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198200","number":198200,"mergeCommit":{"message":"[Security
Solution][Notes] - fix the notes link that is shown twice in the search
bar (#198200)\n\n## Summary\r\n\r\nThis PR fixes a minor inconvenience
where the Kibana search bar was\r\nshowing 2 entries for the new Notes
management page.\r\n\r\n| Before fix | After fix |\r\n| ------------- |
------------- |\r\n| ![Screenshot 2024-10-29 at 11
53\r\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\r\n|
![Screenshot 2024-10-29 at 11
53\r\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\r\n|\r\n\r\nNotes:
this fix does not fix an issue happening in the
space-specific\r\nsearch, where Notes, Timelines and maybe other entries
are appearing\r\ntwice. That issue seems to be related to the way we are
removing then\r\nadding back links to work with the new navigation. I
looked into it but\r\ncould not find a way to fix yet, so this will be
part of a follow up
PR\r\n\r\nhttps://github.com//issues/197694","sha":"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <[email protected]>
  • Loading branch information
kibanamachine and PhilippeOberti authored Oct 30, 2024
1 parent 28a0c15 commit 3feea7b
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ export const links: LinkItem = {
skipUrlState: true,
hideTimeline: true,
hideWhenExperimentalKey: 'securitySolutionNotesDisabled',
globalSearchDisabled: true,
},
],
};
Expand Down

0 comments on commit 3feea7b

Please sign in to comment.