-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[7.17] [Infra] Limit the number of metrics accepted by Metrics Explor…
…er API (#188112) (#188447) # Backport This will backport the following commits from `main` to `7.17`: - [[Infra] Limit the number of metrics accepted by Metrics Explorer API (#188112)](#188112) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-16T13:44:05Z","message":"[Infra] Limit the number of metrics accepted by Metrics Explorer API (#188112)\n\npart of [3628](https://github.com/elastic/observability-dev/issues/3628)\r\n- private\r\n\r\n## Summary\r\n\r\nAfter adding 20 items, users can no longer add more fields and will see\r\nthe message below\r\n\r\n\r\n<img width=\"1725\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/fd504212-0e0f-485d-a8fe-b991c829950e\">\r\n\r\n\r\n### Extra\r\n\r\n- There was an unused and duplicate `metrics_explorer` route in infra. I\r\nremoved it. It should've been removed when the `metrics_data_access`\r\nplugin was created.\r\n- Cleaned up `constants` field in `metrics_data_access` and `infra`\r\nplugins\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure > Metrics Explorer\r\n- Try to select more than 20 fields in the metrics field\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5ec5b994dcc4c47912ad29e6b8da92c4f855041f","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":188112,"url":"https://github.com/elastic/kibana/pull/188112","mergeCommit":{"message":"[Infra] Limit the number of metrics accepted by Metrics Explorer API (#188112)\n\npart of [3628](https://github.com/elastic/observability-dev/issues/3628)\r\n- private\r\n\r\n## Summary\r\n\r\nAfter adding 20 items, users can no longer add more fields and will see\r\nthe message below\r\n\r\n\r\n<img width=\"1725\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/fd504212-0e0f-485d-a8fe-b991c829950e\">\r\n\r\n\r\n### Extra\r\n\r\n- There was an unused and duplicate `metrics_explorer` route in infra. I\r\nremoved it. It should've been removed when the `metrics_data_access`\r\nplugin was created.\r\n- Cleaned up `constants` field in `metrics_data_access` and `infra`\r\nplugins\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure > Metrics Explorer\r\n- Try to select more than 20 fields in the metrics field\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5ec5b994dcc4c47912ad29e6b8da92c4f855041f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188112","number":188112,"mergeCommit":{"message":"[Infra] Limit the number of metrics accepted by Metrics Explorer API (#188112)\n\npart of [3628](https://github.com/elastic/observability-dev/issues/3628)\r\n- private\r\n\r\n## Summary\r\n\r\nAfter adding 20 items, users can no longer add more fields and will see\r\nthe message below\r\n\r\n\r\n<img width=\"1725\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2767137/fd504212-0e0f-485d-a8fe-b991c829950e\">\r\n\r\n\r\n### Extra\r\n\r\n- There was an unused and duplicate `metrics_explorer` route in infra. I\r\nremoved it. It should've been removed when the `metrics_data_access`\r\nplugin was created.\r\n- Cleaned up `constants` field in `metrics_data_access` and `infra`\r\nplugins\r\n\r\n### How to test\r\n\r\n- Start a local Kibana instance pointing to an oblt cluster\r\n- Navigate to Infrastructure > Metrics Explorer\r\n- Try to select more than 20 fields in the metrics field\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5ec5b994dcc4c47912ad29e6b8da92c4f855041f"}},{"url":"https://github.com/elastic/kibana/pull/188442","number":188442,"branch":"8.15","state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
- Loading branch information
1 parent
81dceed
commit 4950f71
Showing
7 changed files
with
197 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters