Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Suppress missing index toast #149836

Closed
stratoula opened this issue Jan 30, 2023 · 4 comments
Closed

[Lens] Suppress missing index toast #149836

stratoula opened this issue Jan 30, 2023 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:
In order to be aligned with Discover #149625, Lens should also suppress the missing index toast and show a useful error message instead

image

Describe a specific use case for the feature:
Implementation: #149625 (comment)

@stratoula stratoula added enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 30, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 30, 2023
@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels Jan 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon
Copy link
Contributor

Technical guidance from @kertal: #149625 (comment)

@stratoula
Copy link
Contributor Author

I was thinking about it, the good news are that with @drewdaemon's changes I don't see the toast anymore:

image

We see no results, exactly as Discover which was the point. Discover has a better no results page but I don't think we want to change this. The only thing we could do is instead of the error about the fields missing we could show something else but I am not sure if we can identify the reason of the erroring.

image

@drewdaemon thoughts?

@drewdaemon
Copy link
Contributor

I think what the current issue was going to cover was

  1. removing the toast (done)
  2. showing some message or icon about there being no matching index

Now that the toasts are removed, I think we can close this in favor of #151526.

The only thing we could do is instead of the error about the fields missing we could show something else but I am not sure if we can identify the reason of the erroring.

We can by checking dataView.matchingIndices.length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants