Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] suppress missing index toasts #150345

Merged

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Feb 6, 2023

Summary

Part of #149836. We will surface this missing index message in Lens later, but for now we're getting rid of the toasts without replacement. Missing field errors still alert the user that something is wrong.

Before:
Screenshot 2023-02-06 at 12 19 11 PM

After:
Screenshot 2023-02-06 at 12 18 14 PM

@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens release_note:skip Skip the PR/issue when compiling release notes labels Feb 6, 2023
@drewdaemon drewdaemon marked this pull request as ready for review February 6, 2023 18:20
@drewdaemon drewdaemon requested a review from a team as a code owner February 6, 2023 18:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More work less toast! 🍞

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #9 / dashboard custom time range by reference can remove a custom time range from a panel
  • [job] [logs] FTR Configs #9 / dashboard custom time range embeddable that does not support time should not show custom time picker in flyout
  • [job] [logs] FTR Configs #39 / Fleet Endpoints EPM Endpoints EPM - get allows user with only package level permission to access corresponding packages

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit ebc1bc5 into elastic:main Feb 6, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants